feat(integration-tests): Test search with the CLP package.#1652
Closed
quinntaylormitchell wants to merge 64 commits intoy-scope:mainfrom
Closed
feat(integration-tests): Test search with the CLP package.#1652quinntaylormitchell wants to merge 64 commits intoy-scope:mainfrom
quinntaylormitchell wants to merge 64 commits intoy-scope:mainfrom
Conversation
…ig file; address comments.
…er-level clp-config.yml
…E_CONFIGS other than clp-text and clp-json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…nning of fixture names.
…over between different modes during testing.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the code that enumerates and facilitates search test jobs that will be run on the CLP package.
Structure
Search jobs are described with the
PackageSearchJobdata class. They are enumerated inclp_job_utils.py. Jobs relevant to the current test run are assembled inPackageJobListfor eachPackageConfigobject by a central job list creator. After the relevant package is spun up, the listed jobs for that package run are dispatched fromdispatch_test_jobsintest_clp_package. Search jobs are run directly after the compression job on which they depend, to prevent searching on multiple compressed archives (archives are cleared after each compression job).All search jobs are run from
search_with_clp_package. Search success is verified by comparing against the ground truth stored in eachPackageSearchJobobject.Command syntax
Command syntax is identical to that introduced in #1651.
PR dependencies
This PR is built on top of the following PRs:
PackageConfigbased on the CLP package config. #1658Dependent PRs
This is a foundational infra PR, and so there are other PRs which depend on this one. They are listed below:
Checklist
breaking change.
Validation performed
Ran all permutations of possible user commands; all succeed.